Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): basic syntax highlighting for geohashes in web console #1318

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

bsmth
Copy link
Contributor

@bsmth bsmth commented Sep 13, 2021

This PR adds support for syntax highlighting of geohash literals:

  • #ezzn5kxb
  • ##11011101010111001010010001010

Copy link
Contributor

@marregui marregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

no need to exclude i and whichever other 5 bit chars are excluded from the base32 alphabet

@bluestreak01 bluestreak01 merged commit 5d7e2e4 into master Sep 13, 2021
@bluestreak01 bluestreak01 deleted the b_ui_geohash_literals branch September 13, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants