-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ilp): preventing occasional data corruption when input contains duplicated columns #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasstiger
requested review from
bluestreak01,
bsmth,
eugenels,
ideoma,
insmac,
mariusgheorghies,
marregui and
rstreics
as code owners
December 16, 2021 11:03
glasstiger
changed the title
ilp(fix): do not clear column cache
fix(ilp): preventing occasional data corruption when input contains duplicated columns
Dec 16, 2021
bluestreak01
requested changes
Dec 17, 2021
core/src/main/java/io/questdb/cutlass/line/tcp/LineTcpMeasurementEvent.java
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/LineTcpMeasurementEvent.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/TableUpdateDetails.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/TableUpdateDetails.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/TableUpdateDetails.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/TableUpdateDetails.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/TableUpdateDetails.java
Outdated
Show resolved
Hide resolved
…irst unresolved column
…irst unresolved column
puzpuzpuz
reviewed
Jan 11, 2022
core/src/test/java/io/questdb/cutlass/line/tcp/LineTcpReceiverFuzzTest.java
Outdated
Show resolved
Hide resolved
[PR Coverage check]😍 pass : 52 / 55 (94.55%) file detail
|
bluestreak01
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ilp fixes, improvements