feat(ui): implement Tree component to handle hierarchical views #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new <Tree/> component * mock integration of it within <Table>
close opened tables when user opens a closed one
it's handled by Tree, no need for duplication
the relevant `useEffect` should ideally be removed, but that requires fixing `refresh` functionality, which is not the scope of this PR and it can be handled separately.
oops, this was added automatically by my tooling, there's no need to prevent prettier in this file
|
|
|
here there is icon for index (int triangle) and partition information circled. These can go into their own groups perhaps ? |
only nest current columns under a `Columns` category. `Columns` is initially open
argshook
requested review from
bluestreak01,
bsmth,
eugenels,
glasstiger,
ideoma,
insmac,
mariusgheorghies,
marregui,
puzpuzpuz and
rstreics
as code owners
argshook
added a commit
to questdb/ui
that referenced
this pull request
Jun 8, 2022
argshook
added a commit
to questdb/ui
that referenced
this pull request
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at solving #1541
It adds a new
<Tree/>component for representing hierarchical viewsEach tree node has an
onOpenhandler - a function that returns a promise. When resolved with appropriate value, that value is used to expand tree node and display new children of tree node. This can continue infinitely through recursion.This PR also integrates
<Tree/>into<Table/>to display columns under a collapsable folder.Component can be used anywhere else where hierarchical structure needs to be represented.
Example usage
