fix(ilp): commit pending rows after a timeout if no further ingestion #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasstiger
requested review from
bluestreak01,
bsmth,
eugenels,
ideoma,
insmac,
mariusgheorghies,
marregui,
puzpuzpuz and
rstreics
as code owners
…-fix-commit-timeout
…-fix-commit-timeout
[PR Coverage check]😍 pass : 27 / 32 (84.38%) file detail
|
bluestreak01
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While ingesting data via ILP there is a commit after a certain number of rows (cairo.max.uncommitted.rows) are inserted into a table.
However, it is likely that there will be a number of rows waiting for commit after ingestion stopped.
A maintenance job runs which will eventually commit these rows.
This job is usually configured to run infrequently (line.tcp.maintenance.job.interval) so it can take some time while the data appears in the database.
This PR will introduce a new config parameter (line.tcp.commit.timeout) which should be set to a much lower number.
If ingestion stops and the table has been idle for the time set in this new config parameter a commit will be issued automatically.