chore: switch to team-based codeowners #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmth
requested review from
bluestreak01,
eugenels,
glasstiger,
ideoma,
insmac,
mariusgheorghies,
marregui,
puzpuzpuz and
rstreics
as code owners
|
hey @pswu11, do you mind reviewing https://github.com/questdb/questdb/blob/codeowners_team/i18n/README.zh-cn.md ? In this PR linter had a go at Chinese readme and I'm not sure if this is just formatting or something more sinister went on? |
|
@bluestreak01 already reviewed & improved the chinese part 👍🏼 |
bluestreak01
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to switch over to a group-based management which does not involve continuously updating codeowners in source control. Anyone in
questdb/engineeringcan be a codeowner for reviews.Members:
https://github.com/orgs/questdb/teams/engineering/members
See also:
This approach is used in the docs repo since last November: https://github.com/questdb/questdb.io/pull/611