fix(cairo): fix reader and txn scoreboard leak #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ideoma
requested review from
bluestreak01,
bsmth,
eugenels,
glasstiger,
insmac,
mariusgheorghies,
marregui,
puzpuzpuz and
rstreics
as code owners
bluestreak01
approved these changes
Jan 5, 2022
[PR Coverage check]😍 pass : 11 / 11 (100.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
txn_scoreboardleak which eventually leads to all SELECT queries being locked withmax txn-inflight limit reachederror.Problem happens when
TableReaderis taken from the pool, it re-reads transaction and fails to reload partitions. If failure happens at this point scoreboard is not released and reader is kept locked out of the pool.Failure to release partition structure is quite likely on busy read/write system because of flaw in O3 purge partition logic which to be fixed separately.