fix(cairo): re-read metadata in TableReader for consistent read #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty-read-fix Conflicts: core/src/main/java/io/questdb/cairo/TableReaderMetadata.java
…-fix Conflicts: core/src/main/java/io/questdb/cairo/TableReader.java core/src/test/java/io/questdb/test/tools/TestUtils.java
…-fix Conflicts: core/src/main/resources/io/questdb/bin/armlinux/libquestdb.so core/src/main/resources/io/questdb/bin/armosx/libquestdb.dylib core/src/main/resources/io/questdb/bin/linux/libquestdb.so core/src/main/resources/io/questdb/bin/osx/libquestdb.dylib core/src/main/resources/io/questdb/bin/windows/libquestdb.dll
- speed up few tests where TableReader times out reload meta - split ci Windows tests into 3 runs
bluestreak01
requested changes
Jan 27, 2022
bluestreak01
approved these changes
Jan 27, 2022
[PR Coverage check]😍 pass : 315 / 327 (96.33%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes few issue on Reader / Writer concurrent use over the table
TableReaderwill re-try reading metadata file on reload if the file is not found for few iterationsTableWriterwill add Structure Version in_metafile which and the value will be the same an in_txnfileTableReaderchecks that Structure Version matches between_metaand_txnfile and if not re-reads bothTableReaderreads_txnfile it reads symbol count and partition size first. If then the transaction check didn't match then subsequent loads will reload of all partitions is used instead of incremental