Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conf): renamed network configuration properties to make names more intuitive #1819

Merged
merged 6 commits into from
Jan 26, 2022

Conversation

bluestreak01
Copy link
Member

@bluestreak01 bluestreak01 commented Jan 21, 2022

Documentation is already up to date:

https://questdb.io/docs/operations/capacity-planning#network-configuration

Also renamed:

http.bind.to -> http.net.bind.to
http.min.bind.to -> http.min.net.bind.to

All old property names are also supported. When both properties present in configuration - new names take precedence

To make names consistent with PG Wire config and ILP.

Documentation PR: https://github.com/questdb/questdb.io/pull/693

@glasstiger glasstiger self-assigned this Jan 26, 2022
@ideoma
Copy link
Collaborator

ideoma commented Jan 26, 2022

[PR Coverage check]

😍 pass : 54 / 55 (98.18%)

file detail

path covered line new line coverage
🔵 io/questdb/network/IODispatcherConfiguration.java 5 6 83.33%
🔵 io/questdb/PropServerConfiguration.java 44 44 100.00%
🔵 io/questdb/network/AbstractIODispatcher.java 4 4 100.00%
🔵 io/questdb/cutlass/line/tcp/LineTcpReceiver.java 1 1 100.00%

@glasstiger glasstiger self-requested a review January 26, 2022 13:02
@bluestreak01 bluestreak01 merged commit 0f1ade9 into master Jan 26, 2022
@bluestreak01 bluestreak01 deleted the vi_conf branch January 26, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants