fix(ilp): case insensitivity for table names via ILP #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluestreak01
approved these changes
Jan 26, 2022
[PR Coverage check]😍 pass : 2 / 2 (100.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when lines ingested via ILP are not consistently using lower/uppercase table names.
If table names were different in case ILP handled them as separate tables which could lead to failures.
One thread could not get the lock to the table and ingestion could fail.
Fix is to use LowerCaseCharSequenceObjHashMap instead of CharSequenceObjHashMap when table name is used as a key in ILP related classes.
Tested by fuzz test.
Benchmarking does not show performance drop, compared to master.