Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cairo): load text_loader.json as a file if cannot be found as a resource #1929

Merged
merged 2 commits into from Mar 4, 2022

Conversation

glasstiger
Copy link
Contributor

QuestDB doc says that a custom version of text_loader.json can be loaded from the conf directory if the below property is set:

cairo.sql.copy.formats.file=text_loader_custom.json

This did not work.
The PR fixes the issue by falling back to loading the file from the conf dir if it cannot be found as a resource.

Closes #1928

@ideoma
Copy link
Collaborator

ideoma commented Mar 4, 2022

[PR Coverage check]

😍 pass : 18 / 25 (72.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/text/types/InputFormatConfiguration.java 11 18 61.11%
🔵 io/questdb/PropServerConfiguration.java 1 1 100.00%
🔵 io/questdb/cutlass/text/DefaultTextConfiguration.java 5 5 100.00%
🔵 io/questdb/cairo/DefaultCairoConfiguration.java 1 1 100.00%

@bluestreak01 bluestreak01 merged commit 14122dd into master Mar 4, 2022
@bluestreak01 bluestreak01 deleted the text-loader-json branch March 4, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load text_loader.json as a file if cannot be found as a resource
3 participants