fix(ui): fix unresponsive ui on hidden tables #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insmac
added
Bug
|
@argshook do you mind reviewing ? |
|
Me and @insmac discussed this in private and are checking if we can avoid some logic entirely. Here's an example https://github.com/questdb/questdb/compare/ui/fix-editor-when-no-tables?expand=1 |
argshook
approved these changes
Mar 21, 2022
argshook
pushed a commit
to questdb/ui
that referenced
this pull request
Jun 8, 2022
argshook
pushed a commit
to questdb/ui
that referenced
this pull request
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in Web Console related to #1951 - an added ability to hide telemetry tables in Schema list - it made SQL editor inoperative in that scenario.
This PR fixes that by refactoring how Query store is initiated, so that an empty array is not set upfront, only when the
tables()query responds with an actual array (empty or not).