Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geohash support for CSV import and export #1971

Merged
merged 5 commits into from Mar 22, 2022
Merged

Add geohash support for CSV import and export #1971

merged 5 commits into from Mar 22, 2022

Conversation

puzpuzpuz
Copy link
Contributor

@puzpuzpuz puzpuzpuz commented Mar 21, 2022 •
edited

Just like with ILP, CSV import supports geohash strings only (no geohash literals), so u33d8 instead of #u33d8.

Also fixes JSON and Text processors failure on RECORD column type.

Docs PR: https://github.com/questdb/questdb.io/pull/772

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior REST API Issues or changes relating to the HTTP endpoints labels Mar 21, 2022
@puzpuzpuz puzpuzpuz self-assigned this Mar 21, 2022
@marregui marregui requested review from marregui and removed request for marregui March 21, 2022 17:21
@puzpuzpuz puzpuzpuz changed the title fix(http): JSON and Text processors failed on RECORD column type Add geohash support for CSV import and export Mar 22, 2022
@ideoma
Copy link
Collaborator

ideoma commented Mar 22, 2022

[PR Coverage check]

😍 pass : 58 / 60 (96.67%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/text/types/GeoHashAdapter.java 14 16 87.50%
🔵 io/questdb/cutlass/text/types/TypeManager.java 3 3 100.00%
🔵 io/questdb/cairo/ColumnType.java 11 11 100.00%
🔵 io/questdb/cutlass/pgwire/PGConnectionContext.java 1 1 100.00%
🔵 io/questdb/cutlass/text/TextMetadataParser.java 1 1 100.00%
🔵 io/questdb/cutlass/http/processors/JsonQueryProcessorState.java 5 5 100.00%
🔵 io/questdb/cairo/GeoHashes.java 6 6 100.00%
🔵 io/questdb/cutlass/http/processors/TextQueryProcessor.java 17 17 100.00%

@puzpuzpuz puzpuzpuz marked this pull request as ready for review March 22, 2022 13:46
@puzpuzpuz puzpuzpuz requested a review from marregui March 22, 2022 14:27
@bluestreak01 bluestreak01 merged commit a27e2e5 into master Mar 22, 2022
@bluestreak01 bluestreak01 deleted the vi_http_bugs branch March 22, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

@marregui marregui Awaiting requested review from marregui

Assignees

@puzpuzpuz puzpuzpuz

Labels
Bug Incorrect or unexpected behavior REST API Issues or changes relating to the HTTP endpoints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puzpuzpuz @ideoma @bluestreak01