Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): fix ignored where clause (order by hour) #2027

Merged
merged 5 commits into from Apr 12, 2022
Merged

fix(sql): fix ignored where clause (order by hour) #2027

merged 5 commits into from Apr 12, 2022

Conversation

eugenels
Copy link
Contributor

Fixes: #2002
Replaces: #2018

@eugenels eugenels mentioned this pull request Apr 12, 2022
Closed
@ideoma
Copy link
Collaborator

ideoma commented Apr 12, 2022

[PR Coverage check]

😍 pass : 46 / 49 (93.88%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/model/QueryModel.java 25 27 92.59%
🔵 io/questdb/griffin/model/ExpressionNode.java 15 16 93.75%
🔵 io/questdb/griffin/SqlCompiler.java 1 1 100.00%
🔵 io/questdb/griffin/SqlCodeGenerator.java 5 5 100.00%

@bluestreak01 bluestreak01 merged commit 618fce5 into master Apr 12, 2022
@bluestreak01 bluestreak01 deleted the fix-issue-2002 branch April 12, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bziobrowski bziobrowski bziobrowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sql with Group by hour(ts) ignores where clause
4 participants
@eugenels @ideoma @bziobrowski @bluestreak01