New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sql): fixed PG ODBC driver compatibility problems #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluestreak01
added
Bug
Incorrect or unexpected behavior
SQL
Issues or changes relating to SQL execution
Java
Improvements that update Java code
labels
Apr 14, 2022
bluestreak01
added
Postgres Wire
Issues or changes relating to Postres wire protocol
Compatibility
Compatibility with third-party tools and services
labels
Apr 18, 2022
bziobrowski
reviewed
Apr 22, 2022
[PR Coverage check]😍 pass : 320 / 331 (96.68%) file detail
|
bziobrowski
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Incorrect or unexpected behavior
Compatibility
Compatibility with third-party tools and services
Java
Improvements that update Java code
Postgres Wire
Issues or changes relating to Postres wire protocol
SQL
Issues or changes relating to SQL execution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2026
PG can execute the following SQL, while without this PR we could not
Notice that
join
is inside braces, which QuestDB was interpreting as sub-query and could not reference tables within by aliasesa
andb
. Now SQL parser will remove bracket in this simplified case to rewrite the above SQL as:to allow aliases to be used.
All "real" sub-queries are not affected.
Also, fixed SQL execution from Excel: