fix: tolerate missing partition folders in 6.2.1 -> 6.3 migration #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluestreak01
requested changes
May 10, 2022
bluestreak01
previously approved these changes
May 11, 2022
ideoma
changed the title
ideoma
changed the title
marregui
reviewed
May 11, 2022
marregui
reviewed
May 11, 2022
[PR Coverage check]😍 pass : 29 / 32 (90.62%) file detail
|
bluestreak01
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When last partition exists in
_txnfile but does not exist on disk (perhaps QuestDB was hard aborted) Mig620 fails.The fix will tolerate missing partitions, including missing last partition assuming column presence in the missing partition is the same as in the proceeding partition.