New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): io_uring prototype #2298
Conversation
1d0d7b8
to
a31db1f
Compare
Looking very good! Ideally we'd need windows and OSX abstractions too, so that Java impls don't have to suffer. Additionally, core/src/main/resources/io/questdb/bin/linux/libasm.a does not need to be checked in, common mistake |
liburing will very likely go away entirely. As for having a single abstraction for all async file APIs, it's tricky. The usual approach is to implement it via a thread pool. We could do that or try to implement different behavior on Linux only. I'd propose to finalize io_uring API on its own, merge it and then try to come up with a common abstraction separately. |
@eugenels thanks for dealing with cmake and static linking! |
[PR Coverage check]😍 pass : 102 / 116 (87.93%) file detail
|
Refs #1867
WIP, as early as it can be
TODOs
ulimit -l
on startup and suggest the user to increase the limitSample