Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): fix order-by priority in case of duplicate column names #2339

Merged
merged 8 commits into from Jul 25, 2022
Merged

fix(sql): fix order-by priority in case of duplicate column names #2339

merged 8 commits into from Jul 25, 2022

Conversation

jerrinot
Copy link
Contributor

fixes #2295

@jerrinot jerrinot changed the title fix(SQL): order by priority fix(sql): order by priority Jul 21, 2022
bziobrowski
bziobrowski previously approved these changes Jul 22, 2022
View reviewed changes
@jerrinot
Copy link
Contributor Author

@bziobrowski thanks for the review, I will add the tests you suggested!

bluestreak01
bluestreak01 requested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@bluestreak01 bluestreak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more tests please

bziobrowski
bziobrowski previously approved these changes Jul 22, 2022
View reviewed changes
@bluestreak01 bluestreak01 changed the title fix(sql): order by priority fix(sql): order by priority in cases of ambiguously defined columns Jul 25, 2022
@ideoma
Copy link
Collaborator

ideoma commented Jul 25, 2022

[PR Coverage check]

😍 pass : 1 / 1 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/SqlOptimiser.java 1 1 100.00%

@bluestreak01 bluestreak01 changed the title fix(sql): order by priority in cases of ambiguously defined columns fix(sql): fix order-by priority in case of duplicate column names Jul 25, 2022
@bluestreak01 bluestreak01 merged commit bc16085 into master Jul 25, 2022
@bluestreak01 bluestreak01 deleted the fixes/order-by-priority branch July 25, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

@bziobrowski bziobrowski bziobrowski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect ORDER BY priority
4 participants
@jerrinot @ideoma @bluestreak01 @bziobrowski