Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use all available cores by default #2392

Merged
merged 1 commit into from Aug 3, 2022

Conversation

puzpuzpuz
Copy link
Contributor

Changes default thread pool counts to make use of all available CPU cores instead of half of them as we do it now. Includes:

  • Minimal size of shared worker thread pool is now 2. That's to avoid starvation (incl. health check) due to a long running query.
  • A few spare cores are left for >8 and >16 cores cases. That's to leave some room to breathe to JVM & OS.

@puzpuzpuz puzpuzpuz added Enhancement Enhance existing functionality Core Related to storage, data type, etc. labels Aug 3, 2022
@puzpuzpuz puzpuzpuz self-assigned this Aug 3, 2022
@puzpuzpuz
Copy link
Contributor Author

cc @javier who also thinks we underutilize available resources with the default configuration.

@ideoma
Copy link
Collaborator

ideoma commented Aug 3, 2022

[PR Coverage check]

😍 pass : 4 / 6 (66.67%)

file detail

path covered line new line coverage
🔵 io/questdb/PropServerConfiguration.java 4 6 66.67%

@bluestreak01 bluestreak01 merged commit 2eef0bf into master Aug 3, 2022
@bluestreak01 bluestreak01 deleted the use_all_cores_by_default branch August 3, 2022 19:46
@puzpuzpuz
Copy link
Contributor Author

@amyshwang we need to update Capacity Planning page now. Is it ok if I update it or you'd prefer to do it yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to storage, data type, etc. Enhancement Enhance existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants