Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql): add position() alias for strpos() #2599

Merged
merged 2 commits into from
Oct 8, 2022
Merged

feat(sql): add position() alias for strpos() #2599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75ede57
feat(sql): Add position alias for strpos
DarthBenro008 Oct 6, 2022
b8548e0
Merge branch 'master' into function/position
bluestreak01 Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 32 additions & 0 deletions core/src/main/java/io/questdb/griffin/engine/functions/str/PositionFunctionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/*******************************************************************************
* ___ _ ____ ____
* / _ \ _ _ ___ ___| |_| _ \| __ )
* | | | | | | |/ _ \/ __| __| | | | _ \
* | |_| | |_| | __/\__ \ |_| |_| | |_) |
* \__\_\\__,_|\___||___/\__|____/|____/
*
* Copyright (c) 2014-2019 Appsicle
* Copyright (c) 2019-2022 QuestDB
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
******************************************************************************/

package io.questdb.griffin.engine.functions.str;

public class PositionFunctionFactory extends StrPosFunctionFactory{
@Override
public String getSignature() {
return "position(SS)";
}
}
2 changes: 2 additions & 0 deletions core/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,8 @@
// strpos
io.questdb.griffin.engine.functions.str.StrPosFunctionFactory,
io.questdb.griffin.engine.functions.str.StrPosCharFunctionFactory,
// position
io.questdb.griffin.engine.functions.str.PositionFunctionFactory,
// Change string case
io.questdb.griffin.engine.functions.str.ToUppercaseFunctionFactory,
io.questdb.griffin.engine.functions.str.ToLowercaseFunctionFactory,
Expand Down
3 changes: 3 additions & 0 deletions core/src/main/resources/META-INF/services/io.questdb.griffin.FunctionFactory
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,9 @@ io.questdb.griffin.engine.functions.groupby.StdDevSampleDoubleGroupByFunctionFac
io.questdb.griffin.engine.functions.str.StrPosFunctionFactory
io.questdb.griffin.engine.functions.str.StrPosCharFunctionFactory

# position()
io.questdb.griffin.engine.functions.str.PositionFunctionFactory

# ^
io.questdb.griffin.engine.functions.math.PowDoubleFunctionFactory
io.questdb.griffin.engine.functions.table.AllTablesFunctionFactory
Expand Down
187 changes: 187 additions & 0 deletions core/src/test/java/io/questdb/griffin/engine/functions/str/PositionFunctionFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,187 @@
/*******************************************************************************
* ___ _ ____ ____
* / _ \ _ _ ___ ___| |_| _ \| __ )
* | | | | | | |/ _ \/ __| __| | | | _ \
* | |_| | |_| | __/\__ \ |_| |_| | |_) |
* \__\_\\__,_|\___||___/\__|____/|____/
*
* Copyright (c) 2014-2019 Appsicle
* Copyright (c) 2019-2022 QuestDB
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
******************************************************************************/

package io.questdb.griffin.engine.functions.str;

import io.questdb.griffin.AbstractGriffinTest;
import org.junit.Test;

public class PositionFunctionFactoryTest extends AbstractGriffinTest {
@Test
public void testStrVar() throws Exception {
assertQuery(
"substr\tstr\tposition\n" +
"XYZ\tABC XYZ XYZ\t5\n" +
"\tXYZ\tNaN\n" +
"\tXYZ\tNaN\n" +
"C\tXYW\t0\n" +
"C\tXYW\t0\n" +
"\tABC XYZ XYZ\tNaN\n" +
"C\tXYW\t0\n" +
"XYZ\tXYZ\t1\n" +
"C\tABC XYZ XYZ\t3\n" +
"C\tXYZ\t0\n" +
"XYZ\t\tNaN\n" +
"\tABC XYZ XYZ\tNaN\n" +
"C\t\tNaN\n" +
"C\tXYW\t0\n" +
"XYZ\t\tNaN\n",
"select substr,str,position(str,substr) from x",
"create table x as (" +
"select rnd_str('ABC XYZ XYZ','XYZ','XYW',NULL) as str\n" +
", rnd_str('XYZ','C',NULL) as substr\n" +
"from long_sequence(15)" +
")",
null,
true,
false,
true
);
}

@Test
public void testStrVarConst() throws Exception {
assertQuery(
"str\tposition\n" +
"ABC XYZ XYZ\t5\n" +
"ABC XYZ XYZ\t5\n" +
"XYZ\t1\n" +
"XYW\t0\n" +
"XYW\t0\n",
"select str,position(str,'XYZ') from x",
"create table x as (" +
"select rnd_str('ABC XYZ XYZ','XYZ','XYW') as str\n" +
"from long_sequence(5)" +
")",
null,
true,
false,
true
);
}

@Test
public void testCharVar() throws Exception {
assertQuery(
"substr\tstr\tposition\n" +
"T\tTEST\t1\n" +
"W\tA X X\t0\n" +
"P\tA X X\t0\n" +
"W\tCDE\t0\n" +
"Y\tCDE\t0\n" +
"X\tTEST\t0\n" +
"E\tCDE\t3\n" +
"N\tA X X\t0\n" +
"X\tTEST\t0\n" +
"Z\tA X X\t0\n" +
"X\t\tNaN\n" +
"X\tTEST\t0\n" +
"B\t\tNaN\n" +
"T\tCDE\t0\n" +
"P\t\tNaN\n",
"select substr,str,position(str,substr) from x",
"create table x as (" +
"select rnd_str('TEST','A X X','CDE',NULL) as str\n" +
", rnd_char() as substr\n" +
"from long_sequence(15)" +
")",
null,
true,
false,
true
);
}

@Test
public void testCharVarConst() throws Exception {
assertQuery(
"str\tposition\n" +
"ABC XYZ XYZ\t3\n" +
"ABC XYZ XYZ\t3\n" +
"CBA\t1\n" +
"XYZ\t0\n" +
"XYZ\t0\n",
"select str,position(str,'C') from x",
"create table x as (" +
"select rnd_str('ABC XYZ XYZ','CBA','XYZ') as str\n" +
"from long_sequence(5)" +
")",
null,
true,
false,
true
);
}

@Test
public void testConstantNull() throws Exception {
assertQuery(
"pos1\tpos2\tpos3\tpos4\n" +
"NaN\tNaN\tNaN\tNaN\n",
"select position(null,'a') pos1, position(null,'abc') pos2, position('a',null) pos3, position(null,null) pos4",
null,
null,
true,
false,
true
);
}

@Test
public void testConstantEmptyString() throws Exception {
assertQuery(
"pos1\tpos2\tpos3\n" +
"0\t1\t1\n",
"select position('','a') pos1, position('a',cast('' as string)) pos2, position('','') pos3",
null,
null,
true,
false,
true
);
}

@Test
public void testSplitColumn() throws Exception {
assertQuery(
"str\tstr1\tstr2\n" +
"dog,cat\tdog\tcat\n" +
"dog,cat\tdog\tcat\n" +
"apple,pear\tapple\tpear\n",
"select str,\n" +
"left(str, position(str, ',') - 1) str1,\n" +
"right(str, length(str) - position(str, ',')) str2\n" +
"from x",
"create table x as (" +
"select rnd_str('dog,cat','apple,pear') as str\n" +
"from long_sequence(3)" +
")",
null,
true,
false,
true
);
}

}