fix(sql): fix order by removal in nested queries inside set operations #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bziobrowski
commented
Feb 7, 2023
[PR Coverage check]😍 pass : 6 / 7 (85.71%) file detail
|
puzpuzpuz
approved these changes
Feb 13, 2023
bluestreak01
deleted the
bz_fix_set_operations_with_order_by_and_limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2904
PR Fixes bad order by ignore/removal in second and later subqueries of set operations (EXCEPT , UNION, UNION ALL, INTERSECT ).
Also fixes bad column name resolution in explain plan for DeferredSingleSymbolFilterDataFrame.