Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): make sure that order by is not ignored by row_number() function #2999

Merged
merged 3 commits into from
Feb 20, 2023
Merged

fix(sql): make sure that order by is not ignored by row_number() function #2999

merged 3 commits into from
Feb 20, 2023

Conversation

puzpuzpuz
Copy link
Contributor

@puzpuzpuz puzpuzpuz commented Feb 17, 2023 •
edited

Closes #2620
Closes #2705

Also fixes an invalid assertion in ReaderPoolTest#testConcurrentRead().

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Feb 17, 2023
@puzpuzpuz puzpuzpuz self-assigned this Feb 17, 2023
@ideoma
Copy link
Collaborator

ideoma commented Feb 17, 2023

[PR Coverage check]

😍 pass : 5 / 5 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/table/FilterOnValuesRecordCursorFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/analytic/RowNumberFunctionFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/analytic/CachedAnalyticRecordCursorFactory.java 1 1 100.00%
🔵 io/questdb/griffin/SqlCodeGenerator.java 2 2 100.00%

@puzpuzpuz
Copy link
Contributor Author

The failed mac-other run is due to Maven repos being unreachable to the CI worker.

jerrinot
jerrinot approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@jerrinot jerrinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code change looks good.
the PR title is alright too.

@puzpuzpuz
Copy link
Contributor Author

@jerrinot thanks for the review!

@bluestreak01 bluestreak01 merged commit 656cd4a into master Feb 20, 2023
@bluestreak01 bluestreak01 deleted the fix_row_number_with_order_by_only branch February 20, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrinot jerrinot jerrinot approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels
Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution
Projects
None yet
Milestone
No milestone
4 participants
@puzpuzpuz @ideoma @jerrinot @bluestreak01