Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): fix inconvertible types error when updating string column #3005

Merged
merged 3 commits into from
Feb 23, 2023
Merged

fix(sql): fix inconvertible types error when updating string column #3005

merged 3 commits into from
Feb 23, 2023

Conversation

puzpuzpuz
Copy link
Contributor

Fixes #3004

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Feb 20, 2023
@puzpuzpuz puzpuzpuz self-assigned this Feb 20, 2023
@ideoma
Copy link
Collaborator

ideoma commented Feb 22, 2023

[PR Coverage check]

😍 pass : 7 / 11 (63.64%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/SqlCompiler.java 7 11 63.64%

@bluestreak01 bluestreak01 merged commit 917929c into master Feb 23, 2023
@bluestreak01 bluestreak01 deleted the improve_string_conversion_in_update branch February 23, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bziobrowski bziobrowski bziobrowski approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels
Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR: inconvertible types: CHAR -> STRING
4 participants
@puzpuzpuz @ideoma @bziobrowski @bluestreak01