Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wal): fix cleaning up after dropped tables #3015

Merged
merged 28 commits into from
Feb 27, 2023

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Feb 22, 2023

Sometimes when QuestDB is restarted often some dropped tables can be left on the disk and QuestDB logs a critical error on startup that they will not be available to query. This happens especially often on Windows.

Also removes the error message

2023-02-22T14:25:55.185855Z E i.q.c.O3PartitionPurgeJob unknown directory [table=cpu~2741, dir=txn_seq]

ideoma and others added 28 commits February 22, 2023 20:52
@ideoma
Copy link
Collaborator Author

ideoma commented Feb 27, 2023

[PR Coverage check]

😍 pass : 148 / 177 (83.62%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/DefaultCairoConfiguration.java 0 2 00.00%
🔵 io/questdb/cutlass/line/tcp/TableUpdateDetails.java 6 20 30.00%
🔵 io/questdb/cairo/wal/seq/TableSequencerAPI.java 12 17 70.59%
🔵 io/questdb/cairo/CommitFailedException.java 6 8 75.00%
🔵 io/questdb/cutlass/line/tcp/LineTcpMeasurementScheduler.java 11 13 84.62%
🔵 io/questdb/cairo/wal/ApplyWal2TableJob.java 12 14 85.71%
🔵 io/questdb/cairo/wal/seq/TableSequencerImpl.java 15 16 93.75%
🔵 io/questdb/cairo/wal/WalPurgeJob.java 56 57 98.25%
🔵 io/questdb/PropServerConfiguration.java 2 2 100.00%
🔵 io/questdb/cairo/wal/CheckWalTransactionsJob.java 2 2 100.00%
🔵 io/questdb/cairo/O3PartitionPurgeJob.java 1 1 100.00%
🔵 io/questdb/PropertyKey.java 2 2 100.00%
🔵 io/questdb/cairo/pool/AbstractMultiTenantPool.java 1 1 100.00%
🔵 io/questdb/cairo/TableNameRegistryFileStore.java 16 16 100.00%
🔵 io/questdb/cairo/AbstractTableNameRegistry.java 1 1 100.00%
🔵 io/questdb/cairo/CairoException.java 5 5 100.00%

@bluestreak01 bluestreak01 changed the title fix(wal): fix dropped tables files cleanup fix(wal): fix cleaning up after dropped tables Feb 27, 2023
@bluestreak01 bluestreak01 merged commit 3b29111 into master Feb 27, 2023
@bluestreak01 bluestreak01 deleted the fix-dropped-wal-table-left-after-restart branch February 27, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants