feat(sql): add optional interval specifier (stride) for timestamp_floor function #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or function's kind argument
bziobrowski
reviewed
Feb 27, 2023
core/src/main/java/io/questdb/griffin/engine/functions/date/TimestampFloorFunctionFactory.java
Show resolved
Hide resolved
|
@amyshwang timestamp_floor()'s description will need updating once this PR is merged . |
bziobrowski
reviewed
Feb 27, 2023
core/src/main/java/io/questdb/griffin/engine/functions/date/TimestampFloorFunctionFactory.java
Outdated
Show resolved
Hide resolved
bziobrowski
reviewed
Feb 27, 2023
core/src/main/java/io/questdb/griffin/engine/functions/date/TimestampFloorFunctionFactory.java
Outdated
Show resolved
Hide resolved
bziobrowski
reviewed
Feb 27, 2023
core/src/test/java/io/questdb/std/datetime/microtime/TimestampsTest.java
Show resolved
Hide resolved
[PR Coverage check]😍 pass : 79 / 84 (94.05%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the 'kind' parameter by including an optional stride interval specifier, denoted as
timestamp_floor('15m', ts). The stride interval must be greater than zero and works for units up to weeks. The implementation of this feature is based on the same logic used in the PostgreSQL functiondate_bin('15 minutes', ts, '1970-01-01 00:00:00.000000').Fixes: #2946