Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): fix index out of bounds errors in GROUP BY when worker pool is configured for HTTP or PGWire #3061

Merged
merged 8 commits into from
Mar 22, 2023

Conversation

puzpuzpuz
Copy link
Contributor

Fixes #3044

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Mar 10, 2023
@puzpuzpuz puzpuzpuz self-assigned this Mar 10, 2023
bluestreak01
bluestreak01 previously approved these changes Mar 13, 2023
@bluestreak01 bluestreak01 requested review from bluestreak01 and removed request for bluestreak01 March 13, 2023 14:00
@bluestreak01 bluestreak01 dismissed their stale review March 13, 2023 14:01

sorry, need to have a closer look

@puzpuzpuz puzpuzpuz force-pushed the ap_fix_npe_in_vect_group_by_factory branch from e792ee1 to ca328b6 Compare March 14, 2023 09:15
@puzpuzpuz puzpuzpuz force-pushed the ap_fix_npe_in_vect_group_by_factory branch from 38849d4 to cd4f04f Compare March 17, 2023 19:32
@ideoma
Copy link
Collaborator

ideoma commented Mar 22, 2023

[PR Coverage check]

😍 pass : 66 / 71 (92.96%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/groupby/vect/GroupByRecordCursorFactory.java 10 12 83.33%
🔵 io/questdb/griffin/engine/PerWorkerLocks.java 23 26 88.46%
🔵 io/questdb/griffin/engine/groupby/vect/GroupByNotKeyedVectorRecordCursorFactory.java 8 8 100.00%
🔵 io/questdb/griffin/engine/table/AsyncFilterAtom.java 5 5 100.00%
🔵 io/questdb/griffin/engine/groupby/vect/VectorAggregateEntry.java 16 16 100.00%
🔵 io/questdb/griffin/SqlCodeGenerator.java 4 4 100.00%

@bluestreak01 bluestreak01 merged commit 7a5247b into master Mar 22, 2023
@bluestreak01 bluestreak01 deleted the ap_fix_npe_in_vect_group_by_factory branch March 22, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuestDB crashes on concurrent rest api requests
3 participants