Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pgwire): fix cursor fetch for asyncpg #3067

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

bziobrowski
Copy link
Contributor

Fixes #1897

Fixes cursor fetches from asyncpg code with:

  • bind variables - asyncpg doesn't seem to specify type of bind variables in Bind message but uses those sent back by server in ParameterDescription
  • Flush commands in between - Flush command shouldn't clear current state on server side but trigger processing pending messaged and pushing buffer content to client .

@bziobrowski bziobrowski changed the title fix(pgwire) : fix cursor fetch for asyncpg fix(pgwire): fix cursor fetch for asyncpg Mar 14, 2023
@ideoma
Copy link
Collaborator

ideoma commented Mar 16, 2023

[PR Coverage check]

😍 pass : 3 / 3 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/pgwire/PGConnectionContext.java 3 3 100.00%

@bluestreak01 bluestreak01 merged commit fec8c6e into master Mar 16, 2023
@bluestreak01 bluestreak01 deleted the bz_fix_asyncpg_fetch branch March 16, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty query result in case of pg-cursor + pg-query-stream Node.js packages
3 participants