Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pgwire): add query cancelling #3130

Merged
merged 8 commits into from
Mar 31, 2023
Merged

feat(pgwire): add query cancelling #3130

merged 8 commits into from
Mar 31, 2023

Conversation

bziobrowski
Copy link
Contributor

ideoma
ideoma reviewed Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@ideoma ideoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments about testing

core/src/test/java/io/questdb/test/cutlass/pgwire/PGJobContextTest.java Show resolved Hide resolved
core/src/test/java/io/questdb/test/cutlass/pgwire/PGJobContextTest.java Show resolved Hide resolved
core/src/test/java/io/questdb/test/cutlass/pgwire/PGJobContextTest.java Show resolved Hide resolved
@ideoma
Copy link
Collaborator

ideoma commented Mar 31, 2023

[PR Coverage check]

😍 pass : 112 / 127 (88.19%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/sql/SqlExecutionCircuitBreaker.java 0 2 00.00%
🔵 io/questdb/griffin/engine/ops/UpdateOperation.java 3 4 75.00%
🔵 io/questdb/cutlass/pgwire/PGConnectionContext.java 31 37 83.78%
🔵 io/questdb/cutlass/pgwire/CircuitBreakerRegistry.java 48 54 88.89%
🔵 io/questdb/cutlass/pgwire/PGWireServer.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/conditional/CaseCommon.java 2 2 100.00%
🔵 io/questdb/std/ThreadLocal.java 3 3 100.00%
🔵 io/questdb/cairo/sql/NetworkSqlExecutionCircuitBreaker.java 16 16 100.00%
🔵 io/questdb/cutlass/Services.java 1 1 100.00%
🔵 io/questdb/griffin/engine/groupby/CountRecordCursorFactory.java 3 3 100.00%
🔵 io/questdb/cairo/CairoException.java 2 2 100.00%

@bluestreak01 bluestreak01 merged commit 99e1809 into master Mar 31, 2023
@bluestreak01 bluestreak01 deleted the bz_pgwire_cancel_query branch March 31, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrinot jerrinot jerrinot left review comments

@ideoma ideoma ideoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bziobrowski @ideoma @jerrinot @bluestreak01