fix(core): fix potential segfault when applying WAL on table with var sized columns #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
added
Bug
puzpuzpuz
force-pushed
the
ap_fix_wal_apply_segfault
branch
from
c5080de
to
290a146
Compare
puzpuzpuz
commented
Mar 29, 2023
ideoma
previously approved these changes
Mar 29, 2023
ideoma
approved these changes
Mar 29, 2023
[PR Coverage check]😍 pass : 12 / 12 (100.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was in the Linux implementation of
Files#copyDataToOffset(). It was setting the destination offset conditionally which led to bugs in situations when the lag was appended to the same column file multiple times.