Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log): fix error logging for long queries #3139

Merged
merged 7 commits into from
Apr 5, 2023
Merged

fix(log): fix error logging for long queries #3139

merged 7 commits into from
Apr 5, 2023

Conversation

bziobrowski
Copy link
Contributor

Changes :

  • Improve error logging for queries exceeding LogRecordSink buffer size by :
    • leaving space for EOL chars (to prevent long log message being truncated and joined with following line)
    • logging query text after error message & errno
  • improve logging of stack overflow error thrown from regex_replace matching a very long string

@bziobrowski
Merge remote-tracking branch 'origin/master' into bz_logging_fix
dd925ed 
# Conflicts:
#	core/src/main/java/io/questdb/log/LogRecordSink.java
#	core/src/main/java/io/questdb/std/str/CharSink.java
@bziobrowski
chore(log): fix merge and tests
4c77a91
@ideoma
Copy link
Collaborator

ideoma commented Apr 5, 2023

[PR Coverage check]

😍 pass : 43 / 50 (86.00%)

file detail

path covered line new line coverage
🔵 io/questdb/std/str/CharSink.java 0 1 00.00%
🔵 io/questdb/griffin/engine/functions/catalogue/SimulateCrashFunctionFactory.java 6 12 50.00%
🔵 io/questdb/griffin/engine/functions/regex/RegexpReplaceStrFunctionFactory.java 8 8 100.00%
🔵 io/questdb/cutlass/http/processors/JsonQueryProcessor.java 17 17 100.00%
🔵 io/questdb/log/LogRecordSink.java 11 11 100.00%
🔵 io/questdb/log/Logger.java 1 1 100.00%

@bluestreak01 bluestreak01 merged commit cb9bd35 into master Apr 5, 2023
17 checks passed
@bluestreak01 bluestreak01 deleted the bz_logging_fix branch April 5, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bziobrowski @ideoma @bluestreak01