Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix non-partitioned table truncate error #3160

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Apr 5, 2023

Fix the error when a non-partitioned table has a column deleted and then truncated.

java.lang.UnsupportedOperationException: null
	at io.questdb.cairo.vm.api.NullMemory.getFd(NullMemory.java:82)
	at io.questdb.cairo.vm.api.MemoryM.isOpen(MemoryM.java:57)
	at io.questdb.cairo.TableWriter.truncate(TableWriter.java:2165)
	at io.questdb.test.griffin.wal.fuzz.TruncateTableOperation.apply(TruncateTableOperation.java:33)
	at io.questdb.test.griffin.O3MaxLagTest.replayTransactions(O3MaxLagTest.java:436)
	at io.questdb.test.griffin.O3MaxLagTest.testFuzz00(O3MaxLagTest.java:514)
	at io.questdb.test.griffin.O3MaxLagTest.testFuzz0(O3MaxLagTest.java:807)

Also, move fuzz (random number generated) test cases into classes with Fuzz in their name to be picked up for Fuzz test CI runs.

@ideoma
Copy link
Collaborator Author

ideoma commented Apr 5, 2023

[PR Coverage check]

😍 pass : 10 / 10 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/TableWriter.java 10 10 100.00%

@bluestreak01 bluestreak01 merged commit ce47909 into master Apr 5, 2023
17 checks passed
@bluestreak01 bluestreak01 deleted the fix-non-partitioned-truncate branch April 5, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants