fix(sql): improve WITHIN operator validation #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[PR Coverage check]😍 pass : 25 / 26 (96.15%) file detail
|
ideoma
approved these changes
Apr 12, 2023
puzpuzpuz
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3159
WITHIN operator works only when there's :
true) or replaced with interval scanInstead of silently ignoring operator when conditions aren't met (and returning wrong results) this PR throws an error .
Another quirk of WITHIN is that it is applied after LATEST BY, which is really unexpected for a WHERE clause element, so I added a warning in https://github.com/questdb/questdb.io/pull/1536 .