feat(sql): add nullif(long,long) SQL function
#3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments nullif(int,int) was expecting a function and a constant integer, and would break in queries like `select nullif(now()::int, now()::int)`. Changed the function to accept functions as both arguments.
NullIf supports now also comparison between long numbers
javier
changed the title
bziobrowski
reviewed
Apr 17, 2023
core/src/main/java/io/questdb/griffin/engine/functions/conditional/NullIfIFunctionFactory.java
Show resolved
Hide resolved
bluestreak01
changed the title
nullif(long,long) SQL function
The former name, NullIfIFunctionFactory was not consistent with other functions. Clearer now, hopefully
Added extra tests for non-constant values for Int and Long types
bziobrowski
approved these changes
Apr 20, 2023
[PR Coverage check]😍 pass : 22 / 22 (100.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullIf supports now also comparison between long numbers