fix(pgwire): fix Rust sqlx crate #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #3204 The sqlx crate sends SYNC request right after login and it expects it receive ReadyNewQuery response.
jerrinot
added
Bug
|
sending as a draft to run all existing tests while turning an ad-hoc Rust code into a hex test-case |
so it's symmetric with creation in the BeforeClass
there is going to be a separate PR with PgCodec
jerrinot
commented
May 2, 2023
core/src/test/java/io/questdb/test/cutlass/pgwire/PGJobContextTest.java
Outdated
Show resolved
Hide resolved
bluestreak01
requested changes
May 2, 2023
core/src/main/java/io/questdb/cutlass/pgwire/PGConnectionContext.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/pgwire/PGConnectionContext.java
Outdated
Show resolved
Hide resolved
this is sufficient to fix the rust sqlx client and it carries a minimal risk. larger changes will be done later, with an appropriate test suite.
[PR Coverage check]😍 pass : 4 / 5 (80.00%) file detail
|
bluestreak01
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3204
The sqlx crate sends SYNC request right after login and it expects it receive ReadyNewQuery response.