Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql): add QuestDB to string returned by version() function #3239

Merged
merged 5 commits into from
May 16, 2023

Conversation

davidcooke2
Copy link
Contributor

Add QuestDB to the end of the version string so it can be differentiated from postgres when using SHOW VERSION()

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

@bziobrowski
Copy link
Contributor

Please fix failing tests.

@bziobrowski
Copy link
Contributor

bziobrowski commented Apr 19, 2023

@davidcooke2
To fix the failing testDotNetHex() you've to:

  • enable traffic dumping via PGConnectionContext.dumpNetworkTraffic [just set it to true]
  • run the test and see the last logged hex dump of network traffic
  • replace it in test's script variable (it's almost the same as one of the lines)
  • disable traffic dumping & run test again

You can observe what's going on in the test with a network sniffer that can analyze PG protocol like Wireshark .

@bziobrowski bziobrowski changed the title Add QuestDB to version string feat(sql): add QuestDB to string returned by version() function Apr 19, 2023
@puzpuzpuz puzpuzpuz added Enhancement Enhance existing functionality Compatibility Compatibility with third-party tools and services labels Apr 19, 2023
@ideoma
Copy link
Collaborator

ideoma commented May 10, 2023

What's the motivation for the change? @puzpuzpuz can you comment on why it's needed?
The change itself looks good, happy to approve when the merge conflict is solved.

@puzpuzpuz
Copy link
Contributor

What's the motivation for the change? @puzpuzpuz can you comment on why it's needed?

AFAIR some 3rd-party tools need to be able to differentiate QDB from vanilla Postgres. This PR comes from Flyway maintainers. See flyway/flyway#3656 for the Flyway counterpart PR.

@bluestreak01
Copy link
Member

if we manage to resolve conflicts, the PR could make it in todays release

@bluestreak01 bluestreak01 merged commit 94c0dd3 into questdb:master May 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compatibility Compatibility with third-party tools and services Enhancement Enhance existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants