Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): add imported table metadata to json response #3249

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

bziobrowski
Copy link
Contributor

@bziobrowski bziobrowski commented Apr 19, 2023

PR adds:

  • partitionBy (always set) and
  • timestamp (only set if there is one)
    fields to import json response.
    It changes header value to show whether csv header was detected (and not just copy import's forceHeader param).

@bziobrowski bziobrowski marked this pull request as draft April 19, 2023 13:44
@bziobrowski bziobrowski changed the title fix(http): use column data from schema if header is not detected in csv feathttp): add imported table metadata to json response Apr 20, 2023
@bziobrowski bziobrowski changed the title feathttp): add imported table metadata to json response feat(http): add imported table metadata to json response Apr 20, 2023
@bziobrowski bziobrowski marked this pull request as ready for review April 27, 2023 12:32
@ideoma
Copy link
Collaborator

ideoma commented Apr 27, 2023

[PR Coverage check]

😍 pass : 7 / 7 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/http/processors/TextImportProcessor.java 5 5 100.00%
🔵 io/questdb/cutlass/http/processors/TextLoaderCompletedState.java 1 1 100.00%
🔵 io/questdb/cutlass/text/TextLoader.java 1 1 100.00%

@bluestreak01 bluestreak01 merged commit 95b930a into master Apr 27, 2023
20 checks passed
@bluestreak01 bluestreak01 deleted the bz_fix_csv_import_with_schema branch April 27, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants