fix(sql): fix column type handling in table_partitions() function #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrinot
previously approved these changes
Apr 19, 2023
core/src/main/java/io/questdb/griffin/engine/table/ShowPartitionsRecordCursorFactory.java
Outdated
Show resolved
Hide resolved
|
I'd change
to fix the related issue. |
|
this would not be the only place that does this |
ideoma
previously approved these changes
Apr 20, 2023
ideoma
reviewed
Apr 21, 2023
There was a problem hiding this comment.
@bluestreak01 is right, there can be other places that use getLong instead of getTimestamp. It's better to support both ways in the cursor.
ideoma
approved these changes
Apr 24, 2023
[PR Coverage check]😍 pass : 21 / 27 (77.78%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3250