Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): fix bad rewrite of limit -N #3261

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

bziobrowski
Copy link
Contributor

Fixes
at least one aggregation function must be present in 'select' clause
error triggered by bad rewrite of limit -N clause .

Example (using demo):

select  timestamp, count(*) as total 
from trades 
sample by 1s 
limit -10

@ideoma
Copy link
Collaborator

ideoma commented Apr 21, 2023

[PR Coverage check]

😍 pass : 14 / 15 (93.33%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/SqlOptimiser.java 14 15 93.33%

@bluestreak01 bluestreak01 merged commit a840561 into master Apr 21, 2023
17 checks passed
@bluestreak01 bluestreak01 deleted the bz_fix_negative_limit_rewrite branch April 21, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants