fix(pgwire): revert reported pg server version back to 11.3 #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partially reverting the change from #3080 #3080 changed the reported version as a side-effect, but the new version was used in PropServerConfiguration only, DefaultPGWireConfiguration stays on 11.3 The result was that most tests reported the version 11.3 to clients while production QuestDB builds reported 15.2. Some Postgres clients adjust behaviour depending on the reported server version and using different version in tests and in production builds means we could not trust tests.
jerrinot
added
Bug
[PR Coverage check]😍 pass : 1 / 1 (100.00%) file detail
|
bluestreak01
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially reverting the change from #3080
#3080 changed the reported version as a side-effect, but the new version was used in PropServerConfiguration only, DefaultPGWireConfiguration stays on 11.3 The result was that most tests reported the version 11.3 to clients while production QuestDB builds reported 15.2. Some Postgres clients adjust behaviour depending on the reported server version and using different version in tests and in production builds means we could not trust tests.