Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix index miss values or contain duplicates in certain commit patterns #3266

Merged
merged 5 commits into from
Apr 24, 2023

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Apr 21, 2023

After adding index testing to fuzz tests few issues were found and fixed

  • WAL tables can miss a range of rows in the index. When rows were applied from lag, indexes were not incrementally built.
  • Non-WAL tables can have duplicated index entries when a row cancel happens on the edge of a partition.

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior Core Related to storage, data type, etc. labels Apr 24, 2023
@ideoma
Copy link
Collaborator Author

ideoma commented Apr 24, 2023

[PR Coverage check]

😍 pass : 5 / 5 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/BitmapIndexWriter.java 1 1 100.00%
🔵 io/questdb/cairo/TableWriter.java 4 4 100.00%

@ideoma ideoma merged commit e4eda40 into master Apr 24, 2023
17 checks passed
@ideoma ideoma deleted the fix-index-writing branch April 24, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect or unexpected behavior Core Related to storage, data type, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants