fix(core): improve database stability after power loss #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluestreak01
commented
May 4, 2023
|
once this PR is merged we need to update this paragraph:
|
…DL or other rare events.
puzpuzpuz
reviewed
May 12, 2023
ideoma
reviewed
May 12, 2023
core/src/main/java/io/questdb/cairo/frm/file/ContiguousFileIndexedFrameColumn.java
Show resolved
Hide resolved
core/src/main/java/io/questdb/cairo/frm/file/ContiguousFileIndexedFrameColumn.java
Show resolved
Hide resolved
puzpuzpuz
reviewed
May 12, 2023
|
@puzpuzpuz @ideoma I think I covered all the comments. Let me know otherwise of if you find anything else |
puzpuzpuz
approved these changes
May 15, 2023
[PR Coverage check]😍 pass : 290 / 357 (81.23%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3276
Fixes #3050
Fixes #2420
Reviewed using msync/fsync and refactored codebase to ensure database recovers data after abrupt power loss.
Method of testing is as follows:
loadTestfrom LineTCPFuzzTest to evaluate durability of metadata changesLineTCPSender03MultiTableMainto evaluate durability of partition squashingWhen drive disappears database may become unstable, SEGFAULT or fail to stop. This matters very little because we're simulating power loss. We don't expect DB instance to keep running.
On startup database starts with no significant rows. It shows uploaded-so-far data correctly and continues WAL apply process. There were no corrupt data structures observed over multiple "power loss" events.