fix(core): allow server to perform graceful shutdown under heavy ILP load #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunra
reviewed
May 18, 2023
core/src/test/java/io/questdb/test/cutlass/line/tcp/LineTcpConnectionContextTest.java
Outdated
Show resolved
Hide resolved
ideoma
approved these changes
May 18, 2023
|
failed #2774 on Mac |
[PR Coverage check]😍 pass : 23 / 23 (100.00%) file detail
|
ideoma
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILP jobs were in greedy mode never releasing thread unless socket is empty. This could lead to bad user experience on smaller instances where ILP jobs run from shared pool.
The fix is to re-queue socket after every measurement. There is no notable impact on performance.
In Summary:
syncis enabledcommit()hanging whensyncfails