-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sql): add auxiliary meta functions to support integration with third party library superset #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hird party libraries
…singleton, and make it available elsewhere in the system.
bziobrowski
reviewed
May 24, 2023
bziobrowski
reviewed
May 24, 2023
bziobrowski
reviewed
May 24, 2023
...src/main/java/io/questdb/griffin/engine/functions/catalogue/FunctionListFunctionFactory.java
Outdated
Show resolved
Hide resolved
bziobrowski
reviewed
May 24, 2023
...java/io/questdb/test/griffin/engine/functions/catalogue/FunctionListFunctionFactoryTest.java
Show resolved
Hide resolved
@bziobrowski thank you for the review :) nice spot the use of a sink ;) (I suppose I did no recall that!! dirty garbage!, too long in Python hahaha) |
[PR Coverage check]😍 pass : 201 / 220 (91.36%) file detail
|
bziobrowski
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new functions keywords and functions to support statements such as:
Function keywords()
Returns a list of all keywords supported by QuestDB:
Function functions()
Returns a table with headers:
const
if the parameter must be a constant expression.FunctionFactory
.Example rows:
Implementation notes
I moved the construction of the FunctionFactoryCache into the CairoEngine, and simplified some signatures.