Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): fix NullPointerException in GROUP BY query with ORDER BY expression #3425

Merged
merged 3 commits into from
Jun 2, 2023
Merged

fix(sql): fix NullPointerException in GROUP BY query with ORDER BY expression #3425

merged 3 commits into from
Jun 2, 2023

Conversation

puzpuzpuz
Copy link
Contributor

Fixes #3420

@puzpuzpuz puzpuzpuz self-assigned this May 30, 2023
@puzpuzpuz puzpuzpuz marked this pull request as draft May 30, 2023 09:06
@puzpuzpuz puzpuzpuz marked this pull request as ready for review May 30, 2023 12:16
@ideoma
Copy link
Collaborator

ideoma commented Jun 1, 2023

[PR Coverage check]

😍 pass : 11 / 11 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/SqlOptimiser.java 11 11 100.00%

@ideoma ideoma merged commit 89241aa into master Jun 2, 2023
20 checks passed
@ideoma ideoma deleted the puzpuzpuz_npe_in_constant_expr_check branch June 2, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideoma ideoma ideoma approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException: Cannot read field "type" because "node" is null with constant expression
2 participants
@puzpuzpuz @ideoma