Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pgwire): gracefully handle a client disconnecting during authentication #3485

Merged
merged 3 commits into from
Jun 13, 2023
Merged

fix(pgwire): gracefully handle a client disconnecting during authentication #3485

merged 3 commits into from
Jun 13, 2023

Conversation

jerrinot
Copy link
Contributor

@jerrinot jerrinot commented Jun 13, 2023 •
edited

todo: test

@jerrinot jerrinot added Bug Incorrect or unexpected behavior Postgres Wire Issues or changes relating to Postres wire protocol labels Jun 13, 2023
@jerrinot jerrinot marked this pull request as draft June 13, 2023 11:10
@jerrinot jerrinot marked this pull request as ready for review June 13, 2023 15:57
@ideoma
Copy link
Collaborator

ideoma commented Jun 13, 2023

[PR Coverage check]

😍 pass : 9 / 11 (81.82%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/pgwire/CleartextPasswordPgWireAuthenticator.java 9 11 81.82%

@ideoma ideoma merged commit c67880e into master Jun 13, 2023
22 checks passed
@ideoma ideoma deleted the jh_pgwire_authenticator_handle_disconnect_on_write branch June 13, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideoma ideoma ideoma approved these changes

Assignees
No one assigned
Labels
Bug Incorrect or unexpected behavior Postgres Wire Issues or changes relating to Postres wire protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerrinot @ideoma