Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix table conversion to WAL when table is altered #3505

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Jun 22, 2023

To fix conversion to WAL in the scenario when a table has had a few ALTER TABLE before the conversion.

Fixes #3500

@ideoma
Copy link
Collaborator Author

ideoma commented Jun 22, 2023

[PR Coverage check]

😍 pass : 10 / 10 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/TableConverter.java 8 8 100.00%
🔵 io/questdb/cairo/TxWriter.java 2 2 100.00%

@ideoma ideoma merged commit d197701 into master Jun 22, 2023
21 checks passed
@ideoma ideoma deleted the fix-to-wal-conversion-after-alter branch June 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot alter table and add/remove column to non-WAL to WAL converted tables
2 participants