Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): fix like/ilike filter on bind variable expression #3542

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

puzpuzpuz
Copy link
Contributor

@puzpuzpuz puzpuzpuz commented Jul 5, 2023

Fixes "use constant or bind variable" error returned by queries with expressions like ILIKE '%' || :str || '%' in the filter.

Also fixes flaky O3FailureTest (Overrides weren't reset due to missing tearDown() call).

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Jul 5, 2023
@puzpuzpuz puzpuzpuz self-assigned this Jul 5, 2023
@ideoma
Copy link
Collaborator

ideoma commented Jul 6, 2023

[PR Coverage check]

😍 pass : 2 / 3 (66.67%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/functions/bind/UuidBindVariable.java 0 1 00.00%
🔵 io/questdb/griffin/engine/functions/regex/AbstractLikeStrFunctionFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/bind/NamedParameterLinkFunction.java 1 1 100.00%

@puzpuzpuz
Copy link
Contributor Author

@bziobrowski could you take another look at this one? I addressed your comment and also fixed an unrelated flaky test (O3FailureTest).

@puzpuzpuz
Copy link
Contributor Author

@bziobrowski thanks for the review!

@bluestreak01 bluestreak01 merged commit dc0464c into master Jul 6, 2023
18 of 21 checks passed
@bluestreak01 bluestreak01 deleted the puzpuzpuz_ilike_concat_bind_var branch July 6, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants