Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): unexpected NullPointerException on COUNT(SELECT ...) query #3565

Merged
merged 2 commits into from
Jul 19, 2023
Merged

fix(sql): unexpected NullPointerException on COUNT(SELECT ...) query #3565

merged 2 commits into from
Jul 19, 2023

Conversation

puzpuzpuz
Copy link
Contributor

@puzpuzpuz puzpuzpuz commented Jul 13, 2023 •
edited

Fixes #3564

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Jul 13, 2023
@puzpuzpuz puzpuzpuz self-assigned this Jul 13, 2023
@ideoma
Copy link
Collaborator

ideoma commented Jul 19, 2023

[PR Coverage check]

😍 pass : 1 / 1 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/SqlParser.java 1 1 100.00%

@ideoma ideoma merged commit 39c6f62 into master Jul 19, 2023
21 checks passed
@ideoma ideoma deleted the puzpuzpuz_npe_in_count_query branch July 19, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bziobrowski bziobrowski bziobrowski approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels
Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException in COUNT(SELECT DISTINCT ...) query
3 participants
@puzpuzpuz @ideoma @bziobrowski