Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): enable prepending jvm flags from docker run #3567

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

1fanwang
Copy link
Contributor

@1fanwang 1fanwang commented Jul 14, 2023

Summary

Closes #3401

Testing Done

  1. Docker build locally which uses the updated script
  2. Docker run locally
➜  ~ docker run -e JVM_PREPEND="-Xmx5g" ac28b181eb77
Found on-demand JVM arguments: -Xmx5g, prepending to JVM args
No arguments found in the configuration, start with default arguments
Running as questdb user
Log configuration loaded from: /var/lib/questdb/conf/log.conf
2023-07-13T23:42:25.817836Z A server-main QuestDB 7.2.2-SNAPSHOT. Copyright (C) 2014-2023, all rights reserved.
2023-07-13T23:42:25.935165Z A server-main OS/Arch linux/arm64 [Vanilla,-1744679816, 64 bits, 4 processors]
  1. Verified the java command ran in the contianer
➜  ~ docker ps
CONTAINER ID   IMAGE          COMMAND                  CREATED              STATUS              PORTS                          NAMES
9a2c7cf3ccae   ac28b181eb77   "/docker-entrypoint.…"   About a minute ago   Up About a minute   8812/tcp, 9000/tcp, 9009/tcp   beautiful_lamarr
# cd /proc
# cd 1
# cat cmdline
/app/bin/java-Xmx5g-XX:ErrorFile=/var/lib/questdb/db/hs_err_pid+%p.log-Dout=/var/lib/questdb/conf/log.conf-mio.questdb/io.questdb.ServerMain-d/var/lib/questdb-f# 

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023

CLA assistant check
All committers have signed the CLA.

@1fanwang 1fanwang changed the title feat: enable prepending jvm flags from docker run feat(core): enable prepending jvm flags from docker run Jul 14, 2023
@puzpuzpuz
Copy link
Contributor

@mariusgheorghies could you review this PR?

@1fanwang 1fanwang force-pushed the yifanstefanwang/dockerJvmFlags branch from b439899 to 51c5a36 Compare July 14, 2023 18:33
@1fanwang
Copy link
Contributor Author

1fanwang commented Jul 20, 2023

@mariusgheorghies could you review this PR?

Thanks @puzpuzpuz , do you have alternative reviewers in mind? still haven't got a review yet on this.

Thank you!

@puzpuzpuz
Copy link
Contributor

Thanks @puzpuzpuz , do you have a group alternative reviewers in mind? still haven't got a review yet on this.

Thank you!

Terribly sorry for the delay. I'm vacationing this week. Will do my best to review your PR on Monday.

@puzpuzpuz puzpuzpuz self-assigned this Jul 21, 2023
@puzpuzpuz puzpuzpuz added Enhancement Enhance existing functionality integration labels Jul 21, 2023
@1fanwang 1fanwang requested a review from puzpuzpuz July 25, 2023 03:20
@puzpuzpuz puzpuzpuz removed their assignment Jul 25, 2023
@puzpuzpuz
Copy link
Contributor

@yifanstefanwang thanks for the contribution!

@bluestreak01 bluestreak01 merged commit 1ea150b into questdb:master Jul 25, 2023
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance existing functionality integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extend the docker-entry script to allow passing additional JVM flags
4 participants