Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix wal to non-wal table conversion leaving table non-writable #3572

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix(core): fix wal to non-wal table conversion leaving table non-writable #3572

merged 2 commits into from
Jul 17, 2023

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Jul 17, 2023

Reset _txn file LAG parameters on conversion to and from WAL type.

@ideoma
Copy link
Collaborator Author

ideoma commented Jul 17, 2023

[PR Coverage check]

😍 pass : 13 / 13 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/TableConverter.java 6 6 100.00%
🔵 io/questdb/cairo/TxWriter.java 7 7 100.00%

@ideoma ideoma merged commit 32fc08a into master Jul 17, 2023
21 checks passed
@ideoma ideoma deleted the fix-wal-2-non-wal-conversion-lag-vals branch July 17, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glasstiger glasstiger glasstiger left review comments

@bziobrowski bziobrowski bziobrowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ideoma @bziobrowski @glasstiger