feat(sql): add column type validation for ALTER COLUMN statements #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
added
Bug
puzpuzpuz
changed the title
puzpuzpuz
force-pushed
the
puzpuzpuz_alter_table_char_sequence_race
branch
from
19ee2a1
to
f69b168
Compare
Also fixes races around CharSequence usage in AlterOperation. The sequences originated in SqlCompiler and were used after the compiler was returned back to the pool leading to data races.
puzpuzpuz
force-pushed
the
puzpuzpuz_alter_table_char_sequence_race
branch
from
f69b168
to
81f547e
Compare
…le_char_sequence_race
core/src/main/java/io/questdb/griffin/engine/ops/AlterOperationBuilder.java
Outdated
Show resolved
Hide resolved
…able_char_sequence_race
ideoma
previously approved these changes
Aug 15, 2023
[PR Coverage check]😍 pass : 45 / 50 (90.00%) file detail
|
|
@bluestreak01 the PR is all green and should be ready for review. |
bluestreak01
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3515
Also fixes races around
CharSequenceusage inAlterOperation. The sequences originated inSqlCompilerand were used after the compiler was returned back to the pool leading to data races. The fix is as simple as keeping the compiler around while we execute the statement (see theOperationExecutorclass).